Cache unhandled exceptions prior to delivery #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, unhandled exceptions were sent immediately to the server, blocking the current thread. In the case that the blocked thread was the main thread, this caused an exception and prevented the report from being sent or cached after the fact because the app would then terminate. This change introduces a third delivery style (in addition to blocking and non-blocking) which writes the report to the error cache and then delivers asynchronously (ASYNC_WITH_CACHE). Fixes #138
|
@kattrali did you test these changes on a device or in a simulator - that's the best way to see if Android craps out |
|
On a device - I can confirm that in the prior release the reports are not sent and this change fixes the regression. I'm open to the test but I'm not sure how we can add a crash to the suite directly, unless I misunderstood. |
lemnik
pushed a commit
that referenced
this pull request
Jun 2, 2021
Create tasks for debug variant which are not run by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, unhandled exceptions were sent immediately to the server,
blocking the current thread. In the case that the blocked thread was the
main thread, this caused an exception and prevented the report from
being sent or cached after the fact because the app would then terminate.
This change introduces a third delivery style (in addition to blocking
and non-blocking) which writes the report to the error cache and then
delivers asynchronously (
ASYNC_WITH_CACHE).Fixes #138