Capture and report Thread.state for Android Runtime threads
#1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7204/add-thread-state
branch
from
52428a2 to
f3a2477
Compare
fractalwrench
approved these changes
Sep 15, 2021
lemnik
force-pushed
the
PLAT-7204/add-thread-state
branch
4 times, most recently
from
18993a6 to
b1d9e2e
Compare
lemnik
force-pushed
the
PLAT-7204/add-thread-state
branch
from
b1d9e2e to
c73f990
Compare
fractalwrench
approved these changes
Sep 27, 2021
lemnik
added a commit
that referenced
this pull request
Sep 29, 2021
* docs: correct changelog entry * test: remove flaky test case * Capture and report `Thread.state` for Android Runtime threads (#1372) * feat(threads): capture and report `Thread.state` for Android Runtime threads * fix(thread state): added nullability annotation to `Thread.State.getDescriptor` * feat(unity): allow Client to be initialised with the Notifier details for reporting (#1386) * Capture ndk thread states (#1390) * feat(threads): add `bsg_thread` to the NDK plugin (#1371) * migrate ndk reports for the new threads property (#1376) * feat(threads): add `bsg_thread` to the NDK plugin * feat(thread state): migrate v5 ndk reports to the new v6 * Capture native thread states (#1384) * feat(thread state): capture and report native thread states in NDK crashes * fix(native threads): native threads obey `Configuration.sendThreads` * test(native threads): test scenarios for native thread reporting * fix(native threads): map native thread-status codes to a descriptive string * fix: updated CHANGELOG for native thread state reporting * v5.14.0 * v5.14.0 - Changelog update Co-authored-by: fractalwrench <[email protected]>
Merged
lemnik
added a commit
that referenced
this pull request
Sep 30, 2021
* docs: correct changelog entry * test: remove flaky test case * Capture and report `Thread.state` for Android Runtime threads (#1372) * feat(threads): capture and report `Thread.state` for Android Runtime threads * fix(thread state): added nullability annotation to `Thread.State.getDescriptor` * feat(unity): allow Client to be initialised with the Notifier details for reporting (#1386) * Capture ndk thread states (#1390) * feat(threads): add `bsg_thread` to the NDK plugin (#1371) * migrate ndk reports for the new threads property (#1376) * feat(threads): add `bsg_thread` to the NDK plugin * feat(thread state): migrate v5 ndk reports to the new v6 * Capture native thread states (#1384) * feat(thread state): capture and report native thread states in NDK crashes * fix(native threads): native threads obey `Configuration.sendThreads` * test(native threads): test scenarios for native thread reporting * fix(native threads): map native thread-status codes to a descriptive string * fix: updated CHANGELOG for native thread state reporting * v5.14.0 * v5.14.0 - Changelog update Co-authored-by: fractalwrench <[email protected]> Co-authored-by: fractalwrench <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Capture and report the Thread.state of all captured threads to help in diagnosing issues.
This PR is a clone of #1367
Design
To separate our implementation from any future platform changes or errors, a new Bugsnag
Thread.Stateenum was introduced, reflecting the possible thread-states currently available on Android. The new enum also includes anUNKNOWNstate which is used in cases where we either cannot capture or map the platform state.Testing
Manual testing with the Example app and a debug server. Updated existing unit tests and end-to-end tests to include checks for the new Thread.State field.