Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify blocking on uncaught exception #137

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Conversation

snmaynard
Copy link
Contributor

Fixes #136. It seems like we should always block on uncaught exception. This is untested for now.

@Pezzah
Copy link
Contributor

Pezzah commented Dec 14, 2016

I was worried about what might happen if the application got stuck in some kind of crash loop, could this just keep sending errors to Bugsnag and prevent the application from closing?

@snmaynard
Copy link
Contributor Author

It should block the thread at that point and then terminate when the uncaught exception handler returns

@saurabh0802chd
Copy link

any ETA on release of this PR?

@kattrali kattrali merged commit 8373b6e into master Dec 20, 2016
@kattrali kattrali deleted the notify-blocking-on-uncaught branch December 20, 2016 00:45
lemnik pushed a commit that referenced this pull request Jun 2, 2021
Support automatic upload when building App Bundles
rich-bugsnag pushed a commit that referenced this pull request Sep 3, 2021
Add mazerunner scenarios for StopSession and ResumeSession
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants