Unity/new session methods #1355
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # bugsnag-android-core/src/main/java/com/bugsnag/android/NativeInterface.java
fractalwrench
approved these changes
Sep 1, 2021
|
Please don't merge this yet, i want to wait until the feature is 100% working on unity just in case changes are needed |
|
@fractalwrench This is ready now and the unity side is done. I'll leave it for you to merge and then before the next unity release we can work out the best place to point the Unity sub mod |
fractalwrench
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the unity notifier the android layer will now handle all session tracking.
Therefore I needed to add StartSession, PauseSession and ResumeSession to the interface so that the Unity layer can interact with the current session.