Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ndk): clearly marked read-only char* arguments as const #1260

Merged
merged 1 commit into from
May 21, 2021
Merged

fix(ndk): clearly marked read-only char* arguments as const #1260

merged 1 commit into from
May 21, 2021

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented May 21, 2021

Goal

Fix the warnings emitted from the C++ compiler related to writable strings:

ISO C++11 does not allow conversion from string literal to 'char *'

Testing

Relied on existing testing

@lemnik lemnik requested review from kstenerud and fractalwrench May 21, 2021 10:40
@lemnik lemnik force-pushed the PLAT-4909/fix-ndk-writable-strings branch from 5306077 to 8f1a470 Compare May 21, 2021 10:42
@lemnik lemnik merged commit b77c525 into next May 21, 2021
@lemnik lemnik deleted the PLAT-4909/fix-ndk-writable-strings branch May 21, 2021 11:03
@fractalwrench fractalwrench mentioned this pull request May 27, 2021
Merged
@bengourley bengourley mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstenerud kstenerud kstenerud approved these changes

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemnik @kstenerud @fractalwrench