Catch exceptions thrown by Context.registerReceiver to prevent rare crashes #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-6514/make-register-receiver-safe
branch
from
7fd9e25 to
9f2a0db
Compare
fractalwrench
force-pushed
the
PLAT-6514/make-register-receiver-safe
branch
from
9f2a0db to
b22381f
Compare
fractalwrench
force-pushed
the
PLAT-6514/make-register-receiver-safe
branch
from
b22381f to
6f5ee75
Compare
kstenerud
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Catches exceptions thrown by Context.registerReceiver to prevent rare crashes.
Specifically this catches
SecurityException, which might be thrown by the OS if it cannot verify that the package registering the receiver has permission to do so,DeadSystemException, which is thrown when the OS is about to restart, andIllegalArgumentException, which is thrown when the process UID does not match the caller ID.Receivers are used to check network connectivity, collect device metadata, and listen to orientation changes, so the effect of catching these exceptions is that Bugsnag's behaviour may degrade in the rare case where
registerReceiver()fails. However, this is seen as preferable to Bugsnag causing process termination.Testing
Added unit tests to verify new methods catch exceptions appropriately.