Update synchronous crash reporting logic #1188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Updates the existing synchronous reporting of launch crashes so that they fit the behaviour of the new spec. Specifically, synchronous delivery should only be attempted for the most recent startup crash.
Changeset
app.isLaunching
is set to true, rather than the previousapp.duration
exceeding a thresholdflushOnLaunch()
so that it creates aFuture
and blocks for 2 seconds callingget()
. This avoids a busy wait that the previous implementation usedEventStore
so that it only looks for the most recent startupcrash, as determined by the timestamp and "startupcrash suffix encoded in the filenameflushOnLaunch()
no longer callsflushAsync()
to improve testabilityTesting
flushOnLaunch()
blocks the main thread for a short duration