Handle remaining JNI calls error handling #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5746/remaining-jni-handling
branch
from
2cdeb94 to
b5b16d3
Compare
fractalwrench
force-pushed
the
PLAT-5746/jni-handling
branch
2 times, most recently
from
72c392d to
b661294
Compare
fractalwrench
force-pushed
the
PLAT-5746/remaining-jni-handling
branch
5 times, most recently
from
bc7213f to
0738da9
Compare
fractalwrench
changed the title
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
requested changes
Jan 29, 2021
| // get the breadcrumb type | ||
| jobject jtype = bsg_safe_get_static_object_field(env, type_class, crumb_type); | ||
| if (jtype == NULL) { | ||
| return; |
There was a problem hiding this comment.
Will crumb_type leak here?
| bsg_safe_new_object(env, trace_class, trace_constructor, class, method, | ||
| filename, frame.line_number); | ||
| if (jframe == NULL) { | ||
| return; |
| jobject jseverity = | ||
| bsg_safe_get_static_object_field(env, severity_class, severity_field); | ||
| if (jseverity == NULL) { | ||
| return; |
There was a problem hiding this comment.
These will leak things as well. This should probably be a c-style RAII
| env, jni_cache->arraylist, jni_cache->arraylist_init_with_obj, keyset); | ||
| if (keylist == NULL) { | ||
| return; |
There was a problem hiding this comment.
These will leak things. Should be c-style RAII
fractalwrench
force-pushed
the
PLAT-5746/remaining-jni-handling
branch
2 times, most recently
from
1c30044 to
0c872c3
Compare
fractalwrench
force-pushed
the
PLAT-5746/remaining-jni-handling
branch
from
0c872c3 to
8bb86a9
Compare
|
Thanks @kstenerud - I've updated the changeset so that the functions use RAII where it seemed appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Checks additional JNI calls in the NDK module for pending exceptions and no-ops, building on #1088. This is achieved by calling ExceptionClear to remove any pending JVM exceptions that could lead to app termination.
Changeset
Added safe versions of the following methods and updated code to check the return value where appropriate:
Testing
Relied on existing test coverage.