Store user information in persistenceDirectory #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
commented
Dec 1, 2020
| @@ -133,9 +134,9 @@ internal class ThreadTestStreamable( | |||
| } | |||
|
|
|||
| internal class CrashyStreamable : JsonStream.Streamable { | |||
| override fun toStream(stream: JsonStream) = TODO("I'll handle this later...") | |||
| override fun toStream(stream: JsonStream) = throw IllegalStateException() | |||
There was a problem hiding this comment.
This prevents an unnecessary TODO from showing up in the Android Studio UI
fractalwrench
force-pushed
the
PLAT-5402/user-persistence
branch
from
adb944a to
22198f3
Compare
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
reviewed
Dec 2, 2020
bugsnag-android-core/src/main/java/com/bugsnag/android/UserStore.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/ImmutableConfig.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/UserStore.kt
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
PLAT-5402/user-persistence
branch
from
22198f3 to
55950f3
Compare
tomlongridge
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Stores user information in the
persistenceDirectory. If legacy user information is set inSharedPreferences, it is migrated from there.Changeset
Clientand then deleted legacySharedPreferencesfileSharedPrefMigratorto read user information, check whether a file exists on disk, and to provide a mechanism for deleting the legacy fileUserRepositoryclassUserStoreclass which loads/saves the user, and migrates the legacy value fromSharedPreferencesUserStateso that it only emits an observable when its value is set, and is not responsible for loading the user from disk. TheUserStoreregisters an observer onUserStatewhich persists the changed user value if requiredDeviceIdStoreso that it only callsloadDeviceIdon the first launch, rather than each timeuserproperty toImmutableConfigwhich mirrorsConfiguration#userTesting
ClientTestintoClientUserTest