Merge pull request #461 from bugsnag/refactor-presized-array-call

Prefer using zero-based array when converting collection
bugsnag · Apr 15, 2019 · 859c21c · 859c21c
2 parents 044a6ad + c94bbce
commit 859c21c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/sdk/src/main/java/com/bugsnag/android/ErrorReader.java b/sdk/src/main/java/com/bugsnag/android/ErrorReader.java
@@ -245,7 +245,7 @@ private static StackTraceElement[] readStackFrames(JsonReader reader) throws IOE
             frames.add(readStackFrame(reader));
         }
         reader.endArray();
-        return frames.toArray(new StackTraceElement[frames.size()]);
+        return frames.toArray(new StackTraceElement[0]);
     }
 
     private static StackTraceElement readStackFrame(JsonReader reader) throws IOException {
@@ -396,7 +396,7 @@ private static ThreadState readThreadState(Configuration config, JsonReader read
             }
         }
         reader.endArray();
-        return new ThreadState(threads.toArray(new CachedThread[threads.size()]));
+        return new ThreadState(threads.toArray(new CachedThread[0]));
     }
 
     private static CachedThread readThread(Configuration config,

diff --git a/sdk/src/main/java/com/bugsnag/android/MetaData.java b/sdk/src/main/java/com/bugsnag/android/MetaData.java
@@ -122,7 +122,7 @@ static MetaData merge(@NonNull MetaData... metaDataList) {
 
         @SuppressWarnings({"unchecked", "rawtypes"})
         MetaData newMeta = new MetaData(mergeMaps(stores.toArray(new Map[0])));
-        newMeta.setFilters(filters.toArray(new String[filters.size()]));
+        newMeta.setFilters(filters.toArray(new String[0]));
 
         return newMeta;
     }

diff --git a/sdk/src/main/java/com/bugsnag/android/ThreadState.java b/sdk/src/main/java/com/bugsnag/android/ThreadState.java
@@ -56,7 +56,7 @@ public ThreadState(@NonNull Configuration config,
     private Thread[] sortThreadsById(Map<Thread, StackTraceElement[]> liveThreads) {
         Set<Thread> threadSet = liveThreads.keySet();
 
-        Thread[] threads = threadSet.toArray(new Thread[threadSet.size()]);
+        Thread[] threads = threadSet.toArray(new Thread[0]);
         Arrays.sort(threads, new Comparator<Thread>() {
             public int compare(@NonNull Thread lhs, @NonNull Thread rhs) {
                 return Long.valueOf(lhs.getId()).compareTo(rhs.getId());