Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reactor-grpc v1.2.4 (#701) #702

Closed

Conversation

andrewbasterfield
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a PR, this is more of a drive-by to get the PR consistent with the other dockerized plugins.

I'll bring this up with the team to gauge whether we want to add this as a community plugin.

Is this blocking you, or is this a nice-to-have contribution?

@andrewbasterfield
Copy link
Author

Thank you for opening a PR, this is more of a drive-by to get the PR consistent with the other dockerized plugins.

I'll bring this up with the team to gauge whether we want to add this as a community plugin.

Is this blocking you, or is this a nice-to-have contribution?

This is a nice-to-have for us

@pkwarren
Copy link
Member

Before committing to long term maintenance of this plugin, we're interested to see if salesforce/reactive-grpc#312 completes first. It would be good to know it is under active development.

@pkwarren
Copy link
Member

pkwarren commented Jan 8, 2024

Thank you for the contribution. We're going to close out this PR for now, as it appears this plugin may not be currently under active development. We're happy to reconsider in the future.

@pkwarren pkwarren closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants