Cleanup TopoSort on module data deps #3632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small optimization to remove uneeded work when sorting module dependencies. No change in behavior.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
commented
Feb 12, 2025
Comment on lines
-162
to
-163
| // There is definitely a better way to do this in one pass for all commits with | ||
| // memoization - this is algorithmically bad. |
There was a problem hiding this comment.
This PR avoids TopoSort on each dep. This function is usually called with one indexed module key, but this comment might be referring to an optimization on multiple module keys.
doriable
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization to remove uneeded work when sorting module dependencies. No change in behavior.