Add --exclude-source-retention-options flag to 'buf build' #2807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag that controls whether source-retention options are included in the output image or descriptor set from
buf build
.I compared the output to
protoc
and did notice one small discrepancy: the code I wrote inprotocompile
leaves an emptyoptions
field if it happens to remove all options (i.e. if they were all source-retention). Butprotoc
clears that field if it ends up empty. I can go make a small PR toprotocompile
, but I don't think the difference really matters or is worth holding any of this up.(Never mind the unrecognized field 8042: I didn't use
--as-file-descriptor-set
withbuf build
when creating these files. So the right-hand column is actually an image, so it has that extraImageFile
field which is interpreted as an unrecognized field ofFileDescriptorProto
.)The file I was testing with included both standard options that are source-only (the extension range declaration stuff, which is why option retention was introduced in the first place) and a custom option with source-only retention: