blockchain: Reconstruct headers from block nodes. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_blocknode_headers
branch
2 times, most recently
from
d90458c to
10750f4
Compare
davecgh
force-pushed
the
blockchain_blocknode_headers
branch
from
10750f4 to
53d1270
Compare
davecgh
force-pushed
the
blockchain_blocknode_headers
branch
5 times, most recently
from
5f3ef4b to
5916954
Compare
This modifies the block node structure to include a couple of extra fields needed to be able to reconstruct the block header from a node, and exposes a new function from chain to fetch the block headers which takes advantage of the new functionality to reconstruct the headers from memory when possible. Finally, it updates both the p2p and RPC servers to make use of the new function. This is useful since many of the block header fields need to be kept in order to form the block index anyways and storing the extra fields means the database does not have to be consulted when headers are requested if the associated node is still in memory. The following timings show representative performance gains as measured from one system: new: Time to fetch 100000 headers: 59ms old: Time to fetch 100000 headers: 4783ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #911
This modifies the block node structure to include a couple of extra fields needed to be able to reconstruct the block header from a node, and exposes a new function from chain to fetch the block headers which takes advantage of the new functionality to reconstruct the headers from memory when possible. Finally, it updates both the p2p and RPC servers to make use of the new function.
This is useful since many of the block header fields need to be kept in order to form the block index anyways and storing the extra fields means the database does not have to be consulted when headers are requested if the associated node is still in memory.
The following timings show representative performance gains as measured from one system: