-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CPython's test_int.py
in CI
#2367
base: master
Are you sure you want to change the base?
Conversation
Hello Austin, Travis CI builds have failed for a few weeks now, and there is no usable error message
Do you have an idea where the problem could come from ? |
I saw your comment about fixing the doctests, and I see some recent green check marks, so maybe you were able to figure it out! Does the problem seem resolved? Brython was out of OSS build credits on Travis during January. I contacted Travis support in early February and got a new supply of credits. Maybe that was causing the errors you were seeing. |
2bf8608
to
889603e
Compare
I'm marking as a draft for the moment because it looks like a few files got out of whack after merging master |
This prevents Qunit from throwing an error 'Uncaught Error: No tests were run.' before loading the Brython tests.
- Skip tests that use subinterpreters - Fix errors in string to int conversions - Allow int() to be called on any class that implements the buffer protocol, not just memoryview - Use the existing invalid() function to generate new int error messages
889603e
to
fbd2c36
Compare
@PierreQuentel I think this PR is now ready for a review! The changes in I'm not sure where the differences in |
Thanks for the update, but I have given up on Travis CI. In order to fix issue #2389 I had to add this line in <script id="webworker_82c5f471-0adf-47b1-8d1c-7bcc11aa54e6" class="webworker" type="text/python" src="z.py">
</script> Travis CI crashed because it doesn't seem to support Coming after a long history of things I had to work on just to make it work, with little benefit in the end (I don't remember many bugs detected by the CI tool that had not been detected with the built-in test suite) I threw in the towel and disabled the feature. |
This PR enables
test_int.py
as part of the Travis build, and fixes a variety of errors caught by the tests.Most of the int tests were already passing! The changes in this PR are:
int(' ')
,int('+')
,int('\t')
, etcint()
to be called onarray.array
objects, and in general, any object that supports the buffer protocolunittest.SkipTest
from_testcapi.py
, so no changes to the int tests were needed here)