Adds weekStartsOn as a DateAdaptor option
#86
Conversation
|
Wow, this is a great feature! I had this on the roadmap(in my head), so it's awesome you took it on. I'll be back on Wednesday to dig into this. Thanks! |
|
No worries, was happy to contribute back to search an awesome calendar component. |
|
Looks like the build is borked up due to Jest/NodeJS eating up more memory than it did a few months ago: I'll have to get that fixed, though I did observe all of your tests are passing. |
|
I'm just going to merge this in for now and unwind the build issues. Thanks! |
|
Awesome, cheers. Do you know when you might release an updated package with this in? |
|
I'm working on cleaning the test up a bit, and it should be done after that. I'll aim for the end of this week, but there are some rough edges with deployment because this had sat for a few months. |
|
This will likely take a bit longer. While you implemented something to control which day the calendar starts with, the events are overlayed on a separate layer. This speeds up rendering greatly, but it means it will need to be handled separately. Currently the calendar re-renders with the new start day, but the events do not. |
|
@scottlovegrove new version has been cut. The updated docs have the start day change available to test. Thanks for the PR! |
|
Thanks, I'll put that to use in my project this weekend :) |
With this
weekStartsOnoption, it's now possible for the consuming app to start what day of the week the calendar should start at.The reason for this is currently it starts on a Sunday, regardless of your locale, so if you're in the UK (like I am), where our week starts on a Monday in the calendar, it looks off for us.
I've done this so it defaults to
sundayso that no change in functionality is required, and no input is required from existing consumers of the package.