Support for record flag #284
Conversation
bin/helpers/capabilityHelper.js
Outdated
| @@ -241,6 +241,14 @@ const validate = (bsConfig, args) => { | |||
| logger.warn(Constants.validationMessages.SPEC_TIMEOUT_NOT_PASSED_ERROR); | |||
| } | |||
|
|
|||
| if(!Utils.isUndefined(bsConfig.run_settings["record"])) { | |||
There was a problem hiding this comment.
if bsConfig.run_settings["record"] is false then I believe, it will go inside this code block and give warnings to users if the project Id or record key is missing which it ideally shouldn't
bin/helpers/capabilityHelper.js
Outdated
| if(!Utils.isUndefined(bsConfig.run_settings["record"])) { | ||
| if(Utils.isUndefined(bsConfig.run_settings.projectId)) { | ||
| logger.warn(Constants.validationMessages.PROJECT_ID_MISSING); | ||
| } else if (Utils.isUndefined(bsConfig.run_settings["record-key"])) { |
There was a problem hiding this comment.
Let's make this a separate if condition and not else if. The reason for this is to let users know on the first try only they are missing both projectId and record-key if they are missing.
| exports.setProjectId = (bsConfig, args) => { | ||
| if(!this.isUndefined(args["projectId"])) { | ||
| return args["projectId"]; | ||
| } else if(!this.isUndefined(bsConfig.run_settings["projectId"])) { |
There was a problem hiding this comment.
Just like env var CYPRESS_RECORD_KEY, we have an env var for project id i.e. CYPRESS_PROJECT_ID. More info is available here.
bin/helpers/capabilityHelper.js
Outdated
| @@ -241,6 +241,15 @@ const validate = (bsConfig, args) => { | |||
| logger.warn(Constants.validationMessages.SPEC_TIMEOUT_NOT_PASSED_ERROR); | |||
| } | |||
|
|
|||
| if(!Utils.isUndefined(bsConfig.run_settings["record"]) && String(bsConfig.run_settings["record"]) == 'true') { | |||
| if(Utils.isUndefined(bsConfig.run_settings.projectId)) { | |||
There was a problem hiding this comment.
let's add check for projectId or record-key being empty strings as well and show the warning.
No description provided.