Fix typos in source code comments #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A potentially confusing one (compule = compute?) and several others I found with a spell checker
erayd
approved these changes
Oct 20, 2023
|
Thanks @rapidcow - I appreciate it. I know what you mean about not wanting to submit a PR for just one spelling correction; I have the same hesitation. Thanks for submitting this larger one which corrects several of them all at once 😁 |
|
Yes :'D and honestly it felt worse given that the fix wasn't even any serious code fix. But I'm glad to help what's within my capability! |
|
It's better for it not to be a code fix, to be honest. Bulk spelling is easy to review and approve, and doesn't end up being mixed in the commit log with functional code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's me again. While I was scouring the source code yesterday I came across the word "Compule" which I didn't quite understand... I suppose it meant "Compute"?
And because I felt bad about just making a one-line change again I ran a spell checker on all other files and corrected those too, yeah 😬 please let me know if my changes were acceptable....