Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve domain matching to reduce false positives #172

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

maximbaz
Copy link
Member

@maximbaz maximbaz commented Sep 26, 2019

@erayd is this what you had in mind for #170?

I also added some comments because this logic becomes quite complex 🙂
(so complex I made a mistake when writing it, as seen in the git history)

Fixes #170

@erayd
Copy link
Collaborator

erayd commented Sep 26, 2019

@maximbaz Almost. I don't think we should match for unknown TLD though. Is there a particular reason why we are doing that currently?

@maximbaz
Copy link
Member Author

maximbaz commented Sep 26, 2019

We support hostnames if they match exactly what's currently in the address bar (case 3 in my comment in the code, initially requested for pi.hole in #62 (comment) and implemented in #107), it seems natural that we also want to support subdomains for such entries (case 2 in my comment in the code, example of that would be if login.pi.hole is currently in the address bar and a user has a pi.hole.gpg pass entry).

In other words, the argument is consistency, if "github.gpg" shows up on "login.github.com", "pi.hole.gpg" should show up on "login.pi.hole".

@maximbaz maximbaz merged commit 14302e9 into browserpass:master Sep 26, 2019
fkneist pushed a commit to fkneist/browserpass-extension that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Single words matching domain extensions
2 participants