Use .index/.indexDeps for module resolution #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test needs work. Don't want to add that net-browserify-stub dep It seems to not like it when you -r something from node_modules; it was OK when you -r with a path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @laduke's test case.
When using
-r, therow.fileproperty doesn't contain a full file path, whilerow.depsdoes. So it was possible that we'd look up a full file path but it was never added to the relevant Map. (this should probably be addressed in browserify too!)row.indexandrow.indexDepsdo reliably match, so we can use those instead. common-shake accepts integers as module names so everything is fine.Fixes #21
Fixes #29