Multiple assignment case #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dy
commented
Jan 11, 2019
| prefix += 'void 0, ' | ||
| // ignore alias assignment expression `exports.a = exports.b = exports.c` | ||
| if (!( | ||
| node.right.type === 'AssignmentExpression' && |
There was a problem hiding this comment.
The naive guess, possibly can be more general.
dy
commented
Jan 11, 2019
| @@ -11,6 +11,6 @@ console.log(/* common-shake removed: exports.a = */ 'hello world') | |||
| function a() {} /* common-shake removed: exports.b = */ void 0, function () { return a }, console.log(a) | |||
| var c = (0, /* common-shake removed: exports.c = */ 'beep boop') | |||
|
|
|||
| /* common-shake removed: exports.d = */ void 0, exports.e = null | |||
dy
commented
Jan 11, 2019
|
📦 0.5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22.
Tested out with huge bundle in audio-formant, seems to work ok now.
All tests pass, not sure what other edge cases there can be.
@goto-bus-stop