Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source persist docs for databricks #313

Merged
merged 1 commit into from
May 12, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented May 12, 2023

Overview

When the source tables are empty, Databricks complains about the column-level comments. This aims to remove this issue for Databricks.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Failing CI issues

Outstanding questions

Not sure how to test this - previously it worked fine with the CI checks, but only failed after merging to master.

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:47 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:47 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:47 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 14:48 — with GitHub Actions Inactive
@glsdown glsdown added the bug Something isn't working label May 12, 2023
Copy link
Member

@dluftspring dluftspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@glsdown glsdown merged commit d6a3fe0 into main May 12, 2023
@glsdown glsdown deleted the fix/fix-databricks-docs-on-empty-tables branch May 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants