[DDO-2308] Don't recursively parse query parameters #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mikeflinn
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Actually, just don't try to parse nested info structs from query parameters at all).
H/T to gin-gonic/gin#1733 for an absolute life-saver here. The struct tags like this will ignore even trying to bind nested structs out of query parameters so we won't hit that fun stack-overflow issue.
Granted I'm, uh, not super sure how on earth to test this. The stack overflow comes up in Gin, from binding in handlers, in a way that the current v2 test infra doesn't really let us check. We'd have to spin up a very full Sherlock server and hit it for tests and I think that's not worth it here.