Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dfp pap gt update #573

Merged
merged 14 commits into from
Aug 20, 2024
Merged

Dfp pap gt update #573

merged 14 commits into from
Aug 20, 2024

Conversation

daniellepace
Copy link
Collaborator

Updated for pap project to use Victor's segs and for new postprocessing.

@daniellepace daniellepace requested a review from lucidtronix July 14, 2024 13:16
@daniellepace daniellepace force-pushed the dfp_pap_gt_update branch 10 times, most recently from 7a77c62 to e0925a0 Compare July 26, 2024 15:15
@daniellepace daniellepace force-pushed the dfp_pap_gt_update branch 7 times, most recently from 66b06eb to f0cb23b Compare July 29, 2024 15:21
@daniellepace daniellepace force-pushed the dfp_pap_gt_update branch 5 times, most recently from 0447020 to 8f06be6 Compare July 29, 2024 15:37
Copy link
Collaborator

@lucidtronix lucidtronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and questions, but looks great @daniellepace! No need to bounce back. sry for the delay in reviewing!

ml4h/arguments.py Outdated Show resolved Hide resolved
ml4h/metrics.py Show resolved Hide resolved
ml4h/explorations.py Outdated Show resolved Hide resolved
ml4h/arguments.py Outdated Show resolved Hide resolved
@daniellepace daniellepace merged commit 311f635 into master Aug 20, 2024
6 checks passed
@daniellepace daniellepace deleted the dfp_pap_gt_update branch August 20, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants