Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcs project #530

Merged
merged 16 commits into from
Sep 19, 2023
Merged

Gcs project #530

merged 16 commits into from
Sep 19, 2023

Conversation

anamika1302
Copy link
Contributor

Updated Docker changes and have latest script to push output to google buckets

Copy link
Collaborator

@lucidtronix lucidtronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but please separate out the change for big query from GCS changes.

LATEST_TAG_GPU="tf2.9-latest-gpu"
LATEST_TAG_CPU="tf2.9-latest-cpu"
LATEST_TAG_GPU="tf2.9-latest-gpu-v1"
LATEST_TAG_CPU="tf2.9-latest-cpu-v1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change back to the defaults

PUSH_TO_LATEST="false"
CPU_ONLY="true"
PUSH_TO_GCR="true"
PUSH_TO_LATEST="true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change back to the defaults

@@ -0,0 +1,53 @@
module go_ml4h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR?

@@ -0,0 +1,241 @@
cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR?

@@ -1,6 +1,6 @@
#!/usr/bin/env bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR? Can you separate out the GCS work from BigQuery stuff

@@ -1,202 +1,212 @@
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR?

@@ -0,0 +1,43 @@
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR?

@@ -1,24 +1,39 @@
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR?

scripts/tf.sh Outdated
DOCKER_IMAGE_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-gpu"
DOCKER_IMAGE_NO_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-cpu"
DOCKER_IMAGE_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-gpu-v1"
DOCKER_IMAGE_NO_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-cpu-v1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to default

@@ -0,0 +1,812 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed for this PR?

@lucidtronix lucidtronix merged commit 5baecb8 into master Sep 19, 2023
@lucidtronix lucidtronix deleted the gcs_project branch September 19, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants