-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gcs project #530
Gcs project #530
Conversation
… pip install for google-cloud-storage library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but please separate out the change for big query from GCS changes.
docker/vm_boot_images/build.sh
Outdated
LATEST_TAG_GPU="tf2.9-latest-gpu" | ||
LATEST_TAG_CPU="tf2.9-latest-cpu" | ||
LATEST_TAG_GPU="tf2.9-latest-gpu-v1" | ||
LATEST_TAG_CPU="tf2.9-latest-cpu-v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change back to the defaults
docker/vm_boot_images/build.sh
Outdated
PUSH_TO_LATEST="false" | ||
CPU_ONLY="true" | ||
PUSH_TO_GCR="true" | ||
PUSH_TO_LATEST="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change back to the defaults
@@ -0,0 +1,53 @@ | |||
module go_ml4h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR?
@@ -0,0 +1,241 @@ | |||
cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR?
@@ -1,6 +1,6 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR? Can you separate out the GCS work from BigQuery stuff
@@ -1,202 +1,212 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR?
@@ -0,0 +1,43 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR?
@@ -1,24 +1,39 @@ | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR?
scripts/tf.sh
Outdated
DOCKER_IMAGE_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-gpu" | ||
DOCKER_IMAGE_NO_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-cpu" | ||
DOCKER_IMAGE_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-gpu-v1" | ||
DOCKER_IMAGE_NO_GPU="gcr.io/broad-ml4cvd/deeplearning:tf2.9-latest-cpu-v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back to default
@@ -0,0 +1,812 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed for this PR?
Updated Docker changes and have latest script to push output to google buckets