VAT naming conventions [VS-410] #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbggrant
approved these changes
May 5, 2022
| } | ||
| inputFileofFileNames: { | ||
| localization_optional: true | ||
| inputFileofFileNames: |
There was a problem hiding this comment.
Not your doing, but don't like the mix of camel case and python style naming here.
There was a problem hiding this comment.
yeah true, we might want to think about standardizing here
mcovarr
force-pushed
the
vat_naming_convention
branch
from
9c26022 to
65111bb
Compare
mcovarr
force-pushed
the
vat_naming_convention
branch
from
65111bb to
c632e02
Compare
Codecov Report
@@ Coverage Diff @@
## ah_var_store #7827 +/- ##
================================================
Coverage ? 86.305%
Complexity ? 35190
================================================
Files ? 2170
Lines ? 164837
Branches ? 17775
================================================
Hits ? 142262
Misses ? 16253
Partials ? 6322 |
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split into two commits: cca546b is whitespace only, 9c26022 is the "good" stuff. Alternatively here are some instructions for ignoring whitespace in reviews, I haven't tried them here yet.