Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using s3 and azure blob storage uri's to GenomicsDB in addition to gcs #7271

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

nalinigans
Copy link
Collaborator

Using underlying functionality from GenomicsDB to validate/specify cloud url's for GenomicsDB workspaces. This allows for the specification of s3 and azure blob storage uri's in addition to gcs for GenomicsDB workspaces. Currently, there are no tests for s3/az uri's, this is just experimental functionality available if needed.

@droazen droazen self-requested a review June 7, 2021 16:37
@droazen droazen self-assigned this Jun 7, 2021
Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Confirmed that the existing cloud-based tests are sufficient to cover these changes, for now.

@droazen droazen merged commit 46f3900 into master Jun 22, 2021
@droazen droazen deleted the genomicsdb_uris branch June 22, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants