Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is recommended to run SetNmMdAndUqTags, and not necessary. #7191

Conversation

derekca
Copy link
Contributor

@derekca derekca commented Apr 8, 2021

The sentence "... It is still necessary to subsequently run SetNmMdAndUqTags before running BQSR." has confused users on the forum. I believe that this step is actually optional, so please verify. Here is the forum post where the issue is raised.
https://gatk.broadinstitute.org/hc/en-us/community/posts/360077484012-SetNmMdAndUqTags-is-mandatory-?page=1#community_comment_360014636751

The sentence "... It is still necessary to subsequently run SetNmMdAndUqTags before running BQSR." has confused users on the forum. I believe that this step is actually optional, so please verify. Here is the forum post where the issue is raised. 
https://gatk.broadinstitute.org/hc/en-us/community/posts/360077484012-SetNmMdAndUqTags-is-mandatory-?page=1#community_comment_360014636751
@gatk-bot
Copy link

gatk-bot commented Apr 8, 2021

Travis reported job failures from build 33612
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud openjdk8 33612.1 logs
cloud openjdk11 33612.14 logs

@droazen
Copy link
Contributor

droazen commented Oct 29, 2021

@jamesemery Could you please review this documentation update for accuracy?

@jamesemery jamesemery merged commit f0b3447 into dc_markduplicatesspark_update_210408 Oct 29, 2021
@jamesemery jamesemery deleted the dc_markduplicatesspark_update_210408-1 branch October 29, 2021 18:39
@droazen droazen restored the dc_markduplicatesspark_update_210408-1 branch October 29, 2021 18:40
jamesemery added a commit that referenced this pull request Oct 29, 2021
jamesemery added a commit that referenced this pull request Oct 29, 2021
@droazen
Copy link
Contributor

droazen commented Oct 29, 2021

This one got merged into the wrong branch (dc_markduplicatesspark_update_210408 instead of master)

jamesemery pushed a commit that referenced this pull request Oct 29, 2021
droazen pushed a commit that referenced this pull request Oct 29, 2021
@droazen
Copy link
Contributor

droazen commented Oct 29, 2021

Replaced by #7535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants