Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcloud docker commands in build_docker.sh #7078

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

droazen
Copy link
Contributor

@droazen droazen commented Feb 12, 2021

"gcloud docker" is no longer supported for the latest docker client versions

"gcloud docker" is no longer supported for the latest docker client versions
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. We only tend to check this particular part of the script whenever we cut a release...

@droazen
Copy link
Contributor Author

droazen commented Feb 16, 2021

Updated the wiki with docker/gcloud setup instructions, and linked to them in a comment at the top of the script.

@droazen droazen merged commit ae06fb7 into master Feb 16, 2021
@droazen droazen deleted the dr_update_gcloud_docker_commands branch February 16, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants