support for non-AS called data #6975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganshand
approved these changes
Nov 20, 2020
| out = "|" + outNotAlleleSpecific + ",1|"; | ||
|
|
||
| } else if (variant.getAlleles().size() == 4) { // GT 1/2 | ||
| // TODO: just replicate rather than distribute, is this right? |
There was a problem hiding this comment.
I think this is close enough. I tended to distribute when I did this for other metrics, but I don't think it matters and we don't want half of a read in the output anyway :)
| if (out == null) { | ||
| // Try to use non-AS version | ||
| // TODO: it looks like the AS_RAW version also trims to a single decimal point?? | ||
| // e.g. MQRankSum=1.465 and turn it into |-0.511,1| |
There was a problem hiding this comment.
I'm confused here, how did 1.465 become -0.511?
There was a problem hiding this comment.
lol -- cut and paste!
kcibul
added a commit
that referenced
this pull request
Jan 29, 2021
* support for non-AS called data * fixed null case
kcibul
added a commit
that referenced
this pull request
Feb 1, 2021
* support for non-AS called data * fixed null case
Marianie-Alphonse
pushed a commit
that referenced
this pull request
Feb 16, 2021
* support for non-AS called data * fixed null case
kcibul
added a commit
that referenced
this pull request
Mar 9, 2021
* support for non-AS called data * fixed null case
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* support for non-AS called data * fixed null case
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.