Switch travis gcloud installation to use noninteractive mode #6974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately we are still getting the error about gcloud.py not found so it seems that the piped installer responses were not the problem: This file is definitely present in a fresh gcloud installation I just created for testing purposes... |
droazen
force-pushed
the
dr_fix_travis_gcloud_install
branch
from
4e9c187 to
45065f3
Compare
droazen
changed the title
droazen
force-pushed
the
dr_fix_travis_gcloud_install
branch
from
2865a7f to
e1c5930
Compare
Our travis gcloud installation scripts relied on piping interactive responses into the stdin of the installer, which is brittle. This patch changes our script to instead run the installer in non-interactive mode.
droazen
force-pushed
the
dr_fix_travis_gcloud_install
branch
from
e1c5930 to
93029af
Compare
droazen
changed the title
|
@lbergelson I've refactored this PR to just keep the switch to using non-interactive mode in the gcloud installer, which I think is worth merging to guard against future issues. Can you re-review? |
lbergelson
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our travis gcloud installation scripts relied on piping interactive responses
into the stdin of the installer, which is brittle.
This patch changes our script to instead run the installer in non-interactive mode.