Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin h5py version to 2.10.0. #6955

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Pin h5py version to 2.10.0. #6955

merged 3 commits into from
Nov 13, 2020

Conversation

cmnbroad
Copy link
Collaborator

It looks like the conda env recently started resolving h5py to v3.1.0, which in turn appears to be incompatible with the keras version we're using, causing the CNNScoreVariants integration tests to fail when keras tries to load the model file (see tensorflow/tensorflow#44467). This PR pins the version to the version used by the last build I could find that succeeded, which is 2.10.0.

@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Nov 10, 2020

Good point on the package version test. I'll pin r-backport and add package tests for those.

Perhaps we can forgo pinning everything, but add a check that fails if the conda environment has been changed in any way?

Some kind of alert when things change would be good, but we'd still need to pin in a situation like this I think?

@samuelklee
Copy link
Contributor

Yes, definitely pin h5py in this case.

Not 100% sure what form the alert should take or what manual interventions should be required when it’s triggered, but perhaps we can discuss at the next dependency meeting.

@gatk-bot
Copy link

Travis reported job failures from build 32095
Failures in the following jobs:

Test Type JDK Job ID Logs
conda openjdk8 32095.5 logs

@droazen
Copy link
Contributor

droazen commented Nov 13, 2020

@cmnbroad @samuelklee Seems like there's at least one test failure on this branch:

PythonEnvironmentIntegrationTest. testGATKPythonEnvironmentPackagePresent
java.lang.AssertionError: The installed version of r-backports does not match the 1.1.10 version that was requested. Check the build log to see the actual version that was resolved by conda.

@samuelklee
Copy link
Contributor

I would guess that we actually do get the requested r-backports 1.1.10, but since this is an R package rather than a python package, the python package version check performed by the failing test is not applicable (i.e., you cannot import r-backports in python).

@droazen
Copy link
Contributor

droazen commented Nov 13, 2020

@samuelklee That certainly makes sense -- I'll push a change to this branch to remove r-backports from the DataProvider in question

@droazen droazen merged commit a75885f into master Nov 13, 2020
@droazen droazen deleted the cn_cnn_deps branch November 13, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants