Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidentally broken travis tests that travis neglected to warn about... #6782

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

jamesemery
Copy link
Collaborator

#6764 might have broken travis. lets fix that.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry I didn't catch this.

@@ -123,6 +123,7 @@ install:
script:
# run a basic sanity check to be sure that gatk doesn't explode
# run tests
# Because the docker build for GATK doesn't include the test code or the src files we have to manually collect them into a location to be mounted in for performing tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish "travis script can't be parsed" showed up as a test failure on travis...

@lbergelson
Copy link
Member

It's wierd. It should show up as an error. I suspect githubu failed to signal travis or travis was offline.

@jamesemery jamesemery merged commit 8fa9927 into master Sep 1, 2020
@jamesemery jamesemery deleted the je_fixBrokenTravisGAHHH branch September 1, 2020 15:18
@jamesemery jamesemery restored the je_fixBrokenTravisGAHHH branch September 1, 2020 15:18
@jamesemery jamesemery deleted the je_fixBrokenTravisGAHHH branch September 1, 2020 15:18
mwalker174 pushed a commit that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants