Refactored and enhanced ArgumentsBuilder #6474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbergelson
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
@davidbenjamin I should have done this a long time ago. Thank you for doing it now. I have 1 real comment. 👍 after that. I'm assuming that the changes to the tests are automatically applied and don't need a careful review.
| @@ -26,200 +26,169 @@ public ArgumentsBuilder(){} | |||
| public ArgumentsBuilder(Object[] args){ | |||
There was a problem hiding this comment.
Could you update the class comment while you're here?
| Assert.assertEquals(args.getArgsArray(), new String[]{"--foo","bar"}); | ||
| Assert.assertEquals(args.getString(), "--foo bar"); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
No love for positional arguments? There might be 1 tool that uses those somewhere....
There was a problem hiding this comment.
addPositional was just a wrapper for add, which struck me as confusing at best, misleading at worst.
Yes. |
davidbenjamin
force-pushed
the
db_args_4550
branch
from
db61ee1 to
982a023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4550
@jonn-smith You seem to be the godfather of this ticket. All the integration test files changed are just the consequence of renaming; the only substance is the changes to ArgumentsBuilder.