Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for cpuPlatform runtime attribute #5335

Merged
merged 1 commit into from
Jan 3, 2020
Merged

add doc for cpuPlatform runtime attribute #5335

merged 1 commit into from
Jan 3, 2020

Conversation

SHuang-Broad
Copy link
Contributor

Something to accompany this PR, which addressed these two issues: GATK Forum and Terra.

@SHuang-Broad
Copy link
Contributor Author

@pshapiro4broad Sorry it took me this long to do this.

@SHuang-Broad
Copy link
Contributor Author

@mcovarr Thanks for the review! Can you please merge it? I don't think I have the permission to merge. Thanks!

@mcovarr
Copy link
Contributor

mcovarr commented Jan 2, 2020

You'll need one more approval first. 😉

Do you really not have permissions to merge this? I was wondering why you created a fork rather than just a branch in the Cromwell repo.

@SHuang-Broad
Copy link
Contributor Author

Ah, I didn't notice that two approvals are required.
I tried to push the branch to this repo but was rejected, hence the forking.
I'm from Methods, btw. That might explain why.

@cjllanwarne cjllanwarne merged commit 9a462e8 into broadinstitute:develop Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants