Commit for code review - contains the latest code from d.o. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidnawrot
reviewed
Mar 22, 2018
| $form['user_button_text'] = array( | ||
| '#type' => 'textfield', | ||
| '#title' => t('User account anonymization button text'), | ||
| '#default_value' => variable_get('commerce_gdpr_user_button_text', 'I want to be forgotten'), |
There was a problem hiding this comment.
It's a default variable value, I thought it should be constant :)
dawidnawrot
reviewed
Mar 26, 2018
commerce_gdpr.admin.inc
Outdated
| * Admin form validate handler. | ||
| */ | ||
| function commerce_gdpr_admin_form_validate($form, &$form_state) { | ||
| if (!is_numeric($form_state['values']['data_retention'])) { |
There was a problem hiding this comment.
better to use by ctype_digit()
This will return TRUE for values like: -5 or 5.98
dawidnawrot
reviewed
Mar 26, 2018
| if (!empty($to_anonymize)) { | ||
| $form['to_anonymize'] = array( | ||
| '#theme' => 'item_list', | ||
| '#title' => t("Accounts subject to anonymization"), |
There was a problem hiding this comment.
dawidnawrot
reviewed
Mar 26, 2018
| if (!empty($already_done)) { | ||
| $form['already_done'] = array( | ||
| '#theme' => 'item_list', | ||
| '#title' => t("Accounts already anonymized"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.