Support use of Breadcrumbs without reset.css #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the change, when using Breadcrumbs without reset.css, the chevron icon between the links was not displayed. The reset stylesheet contains a `content: ""` rule which is applied to the `<li>` elements, and this leads to the icon being shown. We've just added the same rule to breadcrumbs.css, and altered the display rule to align the links and icons in the list items. The rule from reset.css (sanitize.css): https://github.com/csstools/sanitize.css/blob/61c85b6961f684d0124093d97475073bb08f557e/sanitize.css#L102-L105
🦋 Changeset detectedLatest commit: a16773d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
juliuxu
reviewed
Jan 31, 2025
juliuxu
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the change, when using Breadcrumbs without reset.css, the chevron icon between the links was not displayed.
The reset stylesheet contains a
content: ""rule which is applied to the<li>elements, and this leads to the icon being shown. We've just added the same rule to breadcrumbs.css, and altered the display rule to align the links and icons in the list items.The rule from reset.css (sanitize.css):
https://github.com/csstools/sanitize.css/blob/61c85b6961f684d0124093d97475073bb08f557e/sanitize.css#L102-L105