Add support for opaque type aliases #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change supports using opaque type aliases as if they were regular types, i.e. the generated propTypes code is based on the underlying type information.
|
Thanks for the PR! Could you add a test for exporting an opaque type? That's where I see this being useful. |
|
Looks good; ready to merge and release? |
|
Just tested the new version in my app and no more warnings. Release would be awesome. |
|
Published as 23.0.0. Thanks! |
This was referenced Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports using opaque type aliases as if they were regular
types, i.e. the generated propTypes code is based on the underlying
type information.