Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to work with angular 13 #79

Merged
merged 15 commits into from
Dec 13, 2021
Merged

Corrections to work with angular 13 #79

merged 15 commits into from
Dec 13, 2021

Conversation

patou
Copy link
Contributor

@patou patou commented Nov 18, 2021 •
edited
Loading

fix #77
fix #76

Corrections of the schematic :

  • Use $id instead of id in the schema.json
  • Delete polyfills and inlineStyleLanguage in angular.json (config not used in the new jest builder).
  • Migrate all sandboxes projects to angular 13
  • Update jestconfig files in workspace with new format.
  • Update node version in the circleci to 16
  • Add other dependency to remove in project

Ready to review

@patou patou mentioned this pull request Nov 18, 2021
Closed
@patou patou mentioned this pull request Nov 19, 2021
Closed
@patou
Copy link
Contributor Author

patou commented Dec 1, 2021

@schuchard any update for this PR ?

@patou
Copy link
Contributor Author

patou commented Dec 6, 2021

I publish the correction on a new package npm :
https://www.npmjs.com/package/@patoudss/jest-schematic

Juste do :

ng add @patoudss/jest-schematic

@schuchard
Copy link
Collaborator

schuchard commented Dec 7, 2021 •
edited
Loading

@patou, apologies on the delayed response. I've reviewed the PR and it looks good. Would you mind rebasing now that I've merged some other PR's so that I can get this in and test it. Additionally, please retarget this PR for https://github.com/briebug/jest-schematic/tree/feat/support-ng-13.

Thank you

@patou patou changed the base branch from master to feat/support-ng-13 December 9, 2021 09:50
@patou
Copy link
Contributor Author

patou commented Dec 9, 2021

@schuchard I rebase this branche to feat/support-ng-13

@schuchard schuchard merged commit b75f302 into briebug:feat/support-ng-13 Dec 13, 2021
schuchard pushed a commit that referenced this pull request Dec 14, 2021
@patou @schuchard
Corrections to work with angular 13 (#79)
1030b91
@patou patou deleted the corrections-to-work-with-angular-13 branch December 14, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webstik1811 webstik1811 webstik1811 approved these changes

@schuchard schuchard schuchard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 13 - NOT SUPPORTED: keyword "id", use "$id" for schema ID Doesn't work with Angular 12.2 anymore
3 participants
@patou @schuchard @webstik1811