Add Shell Profiles and Fix Pre-Commit #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanzerj
changed the title
|
If you merge with the latest ill take a look at adding the profiles. |
|
@JamesWoolfenden Done! |
|
(I'll take a look at the other PR and see if I can add more of it too, I just need a bit to fix other stuff I'm working on) |
|
@JamesWoolfenden I made a go at the other PR and doing a rebase but the code fails several checkov rules and I'm not actually going to use any of the features it builds on that this PR isn't already implementing. Any chance I can get a review when you have a minute? |
|
LGTM not sure whats going on that other PR but this one seems fine |
|
thanks for the contribution! |
|
Woot thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for shell profiles into this module.