Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Multiple check fixes #6999

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Feb 7, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes #6597
Fixes #6199
Fixes #6069
Fixes #6593

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes



Generated description

Below is a concise technical summary of the changes proposed in this PR:

Enhances and fixes multiple Terraform checks. Updates the AutoScalingLaunchTemplate check to handle mixed instances policy. Improves the RDSInstancePerfInsightsEncryptionWithCMK check to consider cases where performance insights are disabled. Extends the SecretManagerSecret90days check to support rate-based rotation schedules. Adds support for replica instances in the GCPMySQLdbInstancePoint_In_TimeRecoveryBackupIsEnabled check.

TopicDetails
Test Updates Updates test cases to reflect changes in check implementations
Modified files (9)
  • tests/terraform/checks/resource/aws/test_AutoScalingLaunchTemplate.py
  • tests/terraform/checks/resource/aws/example_RDSInstancePerfInsightsEncryptionWithCMK/main.tf
  • tests/terraform/checks/resource/aws/example_AutoScalingLaunchTemplate/main.tf
  • tests/terraform/checks/resource/aws/example_SecretManagerSecret90days/main.tf
  • tests/terraform/runner/test_plan_runner.py
  • tests/terraform/graph/checks/resources/GCPMySQLdbInstancePoint_In_TimeRecoveryBackupIsEnabled/main.tf
  • tests/terraform/checks/resource/aws/test_SecretManagerSecret90days.py
  • tests/terraform/checks/resource/aws/test_RDSInstancePerfInsightsEncryptionWithCMK.py
  • tests/terraform/graph/checks/resources/GCPMySQLdbInstancePoint_In_TimeRecoveryBackupIsEnabled/expected.yaml
Latest Contributors(2)
UserCommitDate
tsmithv11feat-terraform-Add-new...November 27, 2024
maxamelfeat-terraform_plan-ad...September 04, 2024
Check Enhancements Enhances existing Terraform checks to improve accuracy and coverage
Modified files (4)
  • checkov/terraform/checks/resource/aws/SecretManagerSecret90days.py
  • checkov/terraform/checks/graph_checks/gcp/GCPMySQLdbInstancePoint_In_TimeRecoveryBackupIsEnabled.yaml
  • checkov/terraform/checks/resource/aws/RDSInstancePerfInsightsEncryptionWithCMK.py
  • checkov/terraform/checks/resource/aws/AutoScalingLaunchTemplate.py
Latest Contributors(2)
UserCommitDate
tsmithv11platform-terraform-Add...January 21, 2025
gruebelfix-terraform-fix-inva...July 09, 2023
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 deployed to scan-security February 7, 2025 22:34 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment