Add loongarch64 support #1565
Closed
Add loongarch64 support #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
reviewed
Apr 7, 2023
There was a problem hiding this comment.
The LLVM version needs to be bumped to 16 too before we can enable the build. Also, rust-lang/rust#96971 is still not merged yet, let's at least wait for that so we can build anything at all.
include/ring-core/base.h
Outdated
| @@ -83,6 +83,9 @@ | |||
| #elif defined(__ARMEL__) || defined(_M_ARM) | |||
| #define OPENSSL_32_BIT | |||
| #define OPENSSL_ARM | |||
| #elif defined(__loongarch64) | |||
There was a problem hiding this comment.
Suggested change
| #elif defined(__loongarch64) | |
| #elif defined(__loongarch_lp64) |
mk/cargo.sh
Outdated
| @@ -108,6 +108,11 @@ case $target in | |||
| export CARGO_TARGET_X86_64_UNKNOWN_LINUX_MUSL_RUSTFLAGS="$rustflags_self_contained" | |||
| fi | |||
| ;; | |||
| loongarch64-unknown-linux-gnuf64) | |||
| export CC_loongarch64_unknown_linux_gnuf64=clang-$llvm_version | |||
| export CC_loongarch64_unknown_linux_gnuf64=llvm-ar-$llvm_version | |||
There was a problem hiding this comment.
These need to become loongarch64-unknown-linux-gnu after loongson/LoongArch-Documentation#80.
mk/install-build-tools.sh
Outdated
| @@ -72,6 +72,9 @@ case $target in | |||
| --target=i686-unknown-linux-musl|--target=x86_64-unknown-linux-musl) | |||
| use_clang=1 | |||
| ;; | |||
| --target=loongarch64-unknown-linux-gnuf64) | |||
zhaixiaojuan
force-pushed
the
loongarch64-main
branch
from
9c2d122 to
8628219
Compare
zhaixiaojuan
changed the title
|
RFR, Thanks~ |
xen0n
reviewed
May 9, 2023
mk/cargo.sh
Outdated
| loongarch64-unknown-linux-gnu) | ||
| export CC_loongarch64_unknown_linux_gnu=clang-$llvm_version | ||
| export CC_loongarch64_unknown_linux_gnu=llvm-ar-$llvm_version | ||
| export CARGO_TARGET_LOONGARCH64_UNKNOWN_LINUX_GNUF64_LINKER=clang-$llvm_version |
There was a problem hiding this comment.
Suggested change
| export CARGO_TARGET_LOONGARCH64_UNKNOWN_LINUX_GNUF64_LINKER=clang-$llvm_version | |
| export CARGO_TARGET_LOONGARCH64_UNKNOWN_LINUX_GNU_LINKER=clang-$llvm_version |
zhaixiaojuan
force-pushed
the
loongarch64-main
branch
from
8628219 to
d7d319e
Compare
xen0n
reviewed
May 10, 2023
aceice-x
reviewed
Sep 3, 2023
| @@ -109,6 +109,11 @@ case $target in | |||
| export CARGO_TARGET_X86_64_UNKNOWN_LINUX_MUSL_RUSTFLAGS="$rustflags_self_contained" | |||
| fi | |||
| ;; | |||
| loongarch64-unknown-linux-gnu) | |||
| export CC_loongarch64_unknown_linux_gnu=clang-$llvm_version | |||
| export CC_loongarch64_unknown_linux_gnu=llvm-ar-$llvm_version | |||
There was a problem hiding this comment.
Suggested change
| export CC_loongarch64_unknown_linux_gnu=llvm-ar-$llvm_version | |
| export AR_loongarch64_unknown_linux_gnu=llvm-ar-$llvm_version |
There was a problem hiding this comment.
Thanks. I will create a new PR to do this since I have lost authentication to the current PR repository.
|
Tracked in new PR: #1632 |
Thanks. I am closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.