Move cursor to the beginning of the line before erasing #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The \033[K escape sequence signifies 'clear from cursor position to the end of the line'. Without moving the cursor to the beggining of the line first it results in no text being deleted. The behaviour of Carriage Return (\r) in terminal emulators is not formally standardized but it is generally interpreted as a move to the beginning of the line. Fixes briandowns#123
HarryMichal
force-pushed
the
properly-erase-lines
branch
from
e735c90 to
a723f91
Compare
briandowns
approved these changes
Dec 17, 2021
|
Thanks for the contribution! |
strider
added a commit
to strider/rhc
that referenced
this pull request
Jan 21, 2022
In commit [1], we've had to downgrade that package due to a rendering bug[2]. This latter has been fixed upstream[3] and released in the v1.17.0[4]. We can now 'revert' the downgrade to v1.13.0 by upgrading directly to the v1.17.0. [1] 2fc8d7d [2] briandowns/spinner#123 [3] briandowns/spinner#126 [4] https://github.com/briandowns/spinner/releases/tag/v1.17.0 Signed-off-by: Gael Chamoulaud (Strider) <[email protected]>
subpop
pushed a commit
to RedHatInsights/rhc
that referenced
this pull request
Jan 21, 2022
In commit [1], we've had to downgrade that package due to a rendering bug[2]. This latter has been fixed upstream[3] and released in the v1.17.0[4]. We can now 'revert' the downgrade to v1.13.0 by upgrading directly to the v1.17.0. [1] 2fc8d7d [2] briandowns/spinner#123 [3] briandowns/spinner#126 [4] https://github.com/briandowns/spinner/releases/tag/v1.17.0 Signed-off-by: Gael Chamoulaud (Strider) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The \033[K escape sequence signifies 'clear from cursor position to the
end of the line'. Without moving the cursor to the beggining of the line
first it results in no text being deleted. The behaviour of Carriage
Return (\r) in terminal emulators is not formally standardized but it is
generally interpreted as a move to the beginning of the line.
Tested on both Linux and Windows (cmd.exe, WSL2 and Windows Terminal).
Fixes #123