fix: ensure that pg-cloudflare can be used with bundlers that don't know about Cloudflare sockets #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now about Cloudflare sockets
By implementing package.json `exports` we can avoid processing the Cloudflare
specific code, which contains `import ... from "cloudflare:sockets"`, in bundlers such
as Webpack.
If you are bundling for a Worker environment using Webpack then you need to add the
`workerd` condition and ignore `cloudflare:sockets` imports:
**webpack.config.js**
```js
resolve: { conditionNames: ["require", "node", "workerd"] },
plugins: [
new webpack.IgnorePlugin({
resourceRegExp: /^cloudflare:sockets$/,
}),
],
```
|
@petebacondarwin you still working on this (it's set to draft) - getting repeated issues about this & I'd love to help get this one merged in. |
|
Oh sorry. I thought it was set to ready. |
|
Ah great thanks! I'll go ahead & get it released & follow up on the linked issues. ❤️ |
|
what about vite ? |
+1 |
|
@IqbalLx and/or @Feuerhamster - please could you provide a simple reproduction of a problem you have with this library and Vite so that I can debug it and find a solution. |
thijs
pushed a commit
to thijs/node-postgres
that referenced
this pull request
Aug 1, 2023
…now about Cloudflare sockets (brianc#2978) By implementing package.json `exports` we can avoid processing the Cloudflare specific code, which contains `import ... from "cloudflare:sockets"`, in bundlers such as Webpack. If you are bundling for a Worker environment using Webpack then you need to add the `workerd` condition and ignore `cloudflare:sockets` imports: **webpack.config.js** ```js resolve: { conditionNames: ["require", "node", "workerd"] }, plugins: [ new webpack.IgnorePlugin({ resourceRegExp: /^cloudflare:sockets$/, }), ], ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975
By implementing package.json
exportswe can avoid processing the Cloudflare specific code, which containsimport ... from "cloudflare:sockets", in bundlers such as Webpack.If you are bundling for a Worker environment using Webpack then you need to add the
workerdcondition and ignorecloudflare:socketsimports:webpack.config.js