Es6fy

[billouboq]

Change all objects with custom prototypes with ES6 classes and remove self variables by using arrow functions.

If you want I can change var with let-const too

I think the only breaking change is that you can't use query without new anymore :

node-postgres/lib/query.js

Line 18 in e087305

if (!(this instanceof Query)) { return new Query(config, values, callback) }

[charmander]

To avoid breaking changes, maybe it’s best to only include the arrow function commit for now?

[billouboq]

Since all tests pass, don't know if it's a use case and if people are using it alone

[charmander]

People are constructing Query objects explicitly. It may be that they’re all using new, but I don’t think class syntax is worth risking that that’s not the case. It also breaks non-ES6-class inheritance of all the pg types.

This isn’t the sort of thing tests would cover.

[abenhamdine]

IMHO @charmander is totally right, it would be much safer to include such a potential breaking change in a major version.
It's difficult and risky to guess actual usage by the ecosystem, notably for a module downloaded more than 1 million times a month.

[billouboq]

@abenhamdine @charmander what about reverting only query class to function but keep the rest with es6 class ?

[charmander]

As I mentioned in the latest comment, it also stops people from being able to inherit from pg types without using class, so that would still be a breaking change.

[abenhamdine]

@billouboq I think it would be better if the PR would be splitted in several ones :

• use arrow functions
• potential use const/let
• use es6 class (semver major)
  It would ease the review and separate minor/major changes.
  Also brianc will have probably something to say about the es6 class stuff.

[billouboq]

Ok will seperate them, thanks for the review