Prefer constructor injection over properties.

pom.xml

@@ -23,6 +23,13 @@
   </properties>
 
   <dependencies>
+
+    <dependency>
+      <groupId>com.atlassian.sal</groupId>
+      <artifactId>sal-api</artifactId>
+      <version>2.7.0</version>
+      <scope>provided</scope>
+    </dependency>
     <dependency>
       <groupId>com.atlassian.confluence</groupId>
       <artifactId>confluence</artifactId>

src/main/java/com/drunkendev/confluence/plugins/attachments/PurgeAttachmentsJob.java

@@ -47,41 +47,28 @@
 public class PurgeAttachmentsJob extends AbstractJob {
 
     private static final Logger LOG = LoggerFactory.getLogger(PurgeAttachmentsJob.class);
-    private AttachmentManager attachmentManager;
-    private SpaceManager spaceManager;
-    private PurgeAttachmentsSettingsService settingSvc;
-    private MultiQueueTaskManager mailQueueTaskManager;
-    private SettingsManager settingsManager;
-    private TransactionTemplate transactionTemplate;
+    private final AttachmentManager attachmentManager;
+    private final SpaceManager spaceManager;
+    private final PurgeAttachmentsSettingsService settingSvc;
+    private final MultiQueueTaskManager mailQueueTaskManager;
+    private final SettingsManager settingsManager;
+    private final TransactionTemplate transactionTemplate;
 
     /**
      * Creates a new {@code PurgeAttachmentsJob} instance.
      */
-    public PurgeAttachmentsJob() {
+    public PurgeAttachmentsJob(AttachmentManager attachmentManager,
+                               SpaceManager spaceManager,
+                               PurgeAttachmentsSettingsService purgeAttachmentsSettingsService,
+                               MultiQueueTaskManager mailQueueTaskManager,
+                               SettingsManager settingsManager,
+                               TransactionTemplate transactionTemplate) {
         LOG.debug("Creating purge-old-attachment-job instance.");
-    }
-
-    public void setAttachmentManager(AttachmentManager attachmentManager) {
         this.attachmentManager = attachmentManager;
-    }
-
-    public void setSpaceManager(SpaceManager spaceManager) {
         this.spaceManager = spaceManager;
-    }
-
-    public void setPurgeAttachmentsSettingsService(PurgeAttachmentsSettingsService purgeAttachmentsSettingsService) {
         this.settingSvc = purgeAttachmentsSettingsService;
-    }
-
-    public void setMultiQueueTaskManager(MultiQueueTaskManager mailQueueTaskManager) {
         this.mailQueueTaskManager = mailQueueTaskManager;
-    }
-
-    public void setSettingsManager(SettingsManager settingsManager) {
         this.settingsManager = settingsManager;
-    }
-
-    public void setTransactionTemplate(TransactionTemplate transactionTemplate) {
         this.transactionTemplate = transactionTemplate;
     }