Support stack collapse for multi-event perf.data files #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah excellent - there are even tests! I'll fix those |
Consider the perf.data file resulting from the following command:
perf record -e cycles,instructions,cache-misses
Creating a flamegraph for such a file is currently impossible.
Or, well, it's possible but the resulting file is meaningless and
misleading, as it will aggregate all samples for the different
event types.
This patch adds `--event-filter <event-type>` to create meaningful
flamegraphs from multi-event perf.data files. We can use it like
this:
perf script | stackcollapse-perf --event-filter cycles
By default, only the samples for the first encountered event type
will be used.
milianw
force-pushed
the
wip/multi-event-perf-data-files
branch
from
d0c2905 to
4b7b316
Compare
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the perf.data file resulting from the following command:
Creating a flamegraph for such a file is currently impossible.
Or, well, it's possible but the resulting file is meaningless and
misleading, as it will aggregate all samples for the different
event types.
This patch adds
--event-filter <event-type>to create meaningfulflamegraphs from multi-event perf.data files. We can use it like
this:
By default, only the samples for the first encountered event type
will be used.