Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force HTTP header to string #1574

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Force HTTP header to string #1574

merged 1 commit into from
Jun 22, 2023

Conversation

starred-gijs
Copy link
Contributor

Fixes #1539

I also found another usage in Psr7Bridge

I used the tests for the custom header and adjusted them to use a numeric header, feedback welcome.

@starred-gijs starred-gijs mentioned this pull request Jun 22, 2023
Closed
@mnapoli
Copy link
Member

mnapoli commented Jun 22, 2023

Thank you!

@mnapoli mnapoli added the bug label Jun 22, 2023
@mnapoli mnapoli merged commit 888055c into brefphp:master Jun 22, 2023
@GrahamCampbell
Copy link
Contributor

This is the one thing I hate about PHP. Numeric array keys that are strings get converted to ints. 😭

@GrahamCampbell
Copy link
Contributor

I just want my Map<string, string, so often.

@starred-gijs starred-gijs deleted the fix-numeric-headers branch June 22, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError Handling Headers with FpmHandler
3 participants
@starred-gijs @mnapoli @GrahamCampbell