Improve the error message when returning a payload above the Lambda limits #1483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1368, also reported in Slack.
Before, when returning a response above the Lambda limits (6MB), users would get the following logs:
This PR improves this specific error so that it's much clearer:
On top of that, the PR also adds low-level details for other Runtime API errors. This lets us more easily debug/understand what went wrong. In our example, it helps us understand the second error (403):
Thanks to that, we now know that after a 413 we shouldn't call the "signal failure" API. That removes the second error:
Positive side-effect: the runtime is no longer in an unknown state (because of unknown errors) and it will not restart PHP-FPM + the whole runtime 💪