This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
fix sorting #284
Merged
fix sorting #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyBarabash
force-pushed
the
fix_sorting
branch
from
cb04c34 to
0cd04d0
Compare
AlexeyBarabash
force-pushed
the
fix_sorting
branch
from
0cd04d0 to
75dddbe
Compare
AlexeyBarabash
added a commit
that referenced
this pull request
Mar 5, 2019
Merge pull request #284 from brave/fix_sorting into master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting of records by timestamp was broken.
This PR particularly addresses brave/brave-browser#3515 , it does not prevent re-appearing of records, but now as records will be provided sorted, then old parasite records will be neutralized by the new record.
In other words <...,CREATE, CREATE,...> or <...,DELETE, DELETE,...> or <...,UPDATE, UPDATE,...> safe. The only potential possibility of error is to have parasite records later than in the next request.